-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13896][SQL]Dataset.toJSON should return Dataset[String] #11732
Conversation
Test build #53201 has finished for PR 11732 at commit
|
Test build #53198 has finished for PR 11732 at commit
|
@@ -1987,9 +1987,9 @@ class Dataset[T] private[sql]( | |||
* @group rdd | |||
* @since 1.3.0 | |||
*/ | |||
def toJSON: RDD[String] = { | |||
def toJSON: Dataset[String] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we'd need to update the documentation above.
Actually I'm just going to merge this and fix the doc myself later. Thanks. |
i missed the docs...my bad... |
## What changes were proposed in this pull request? This patch merges DatasetHolder and DataFrameHolder. This makes more sense because DataFrame/Dataset are now one class. In addition, fixed some minor issues with pull request #11732. ## How was this patch tested? Updated existing unit tests that test these implicits. Author: Reynold Xin <rxin@databricks.com> Closes #11737 from rxin/SPARK-13898.
## What changes were proposed in this pull request? Change the return type of toJson in Dataset class ## How was this patch tested? No additional unit test required. Author: Stavros Kontopoulos <stavros.kontopoulos@typesafe.com> Closes apache#11732 from skonto/fix_toJson.
## What changes were proposed in this pull request? This patch merges DatasetHolder and DataFrameHolder. This makes more sense because DataFrame/Dataset are now one class. In addition, fixed some minor issues with pull request apache#11732. ## How was this patch tested? Updated existing unit tests that test these implicits. Author: Reynold Xin <rxin@databricks.com> Closes apache#11737 from rxin/SPARK-13898.
What changes were proposed in this pull request?
Change the return type of toJson in Dataset class
How was this patch tested?
No additional unit test required.